Comfy-Org / comfy-cli

Command Line Interface for Managing ComfyUI
https://comfydocs.org/comfy-cli/getting-started
GNU General Public License v3.0
123 stars 15 forks source link

Table headers? #96

Open liusida opened 2 weeks ago

liusida commented 2 weeks ago
(Comfy) [clash] PS C:\ComfyUI> comfy node show all
Execute from: C:\ComfyUI\comfy-dummy
[ComfyUI-Manager]  'distutils' package not found. Activating fallback mode for compatibility.
FETCH DATA from: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json [DONE]
[    ENABLED    ]  ComfyUI-Manager                                    manager              (author: Dr.Lt.Data)
[ NOT INSTALLED ]  ComfyUI-Impact-Pack                                impact               (author: Dr.Lt.Data)
[ NOT INSTALLED ]  ComfyUI-Inspire-Pack                               inspire              (author: Dr.Lt.Data)
[ NOT INSTALLED ]  ComfyUI_experiments                                comfy-exp            (author: comfyanonymous)
[ NOT INSTALLED ]  ComfyUI_TensorRT                                   tensorrt             (author: comfyanonymous)
[ NOT INSTALLED ]  ComfyUI-SAI_API                                    sai-api              (author: Stability-AI)

It would be great to have a header for this table, what are in the second column? what are in the third one? I am not sure.

liusida commented 2 weeks ago

I guess they are from the json file: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json

        {
            "author": "Sida Liu",
            "title": "ComfyUI-Login",
            "id": "login",
            "reference": "https://github.com/liusida/ComfyUI-Login",
            "files": [
                "https://github.com/liusida/ComfyUI-Login"
            ],
            "install_type": "git-clone",
            "description": "A simple password to protect ComfyUI."
        },

Right?

How is this related to ComfyUI Registry? How can users install custom nodes in the ComfyUI Registry?

robinjhuang commented 2 weeks ago

@liusida ComfyUI manager will support installing from the registry very soon. For now you can install using comfy node registry-install <node>. It is a beta feature right now so might have bugs.

ltdrdata commented 2 weeks ago

@liusida ComfyUI manager will support installing from the registry very soon. For now you can install using comfy node registry-install <node>. It is a beta feature right now so might have bugs.

Since there are differences between the current installation method using registry-install and the future method that will be supported by ComfyUI-Manager, caution is needed regarding this matter.

When managing with ComfyUI-Manager, it will use an explicitly displayed directory name in the format <node-id>@<version>. To support updates, a .tracking file will be created during the installation phase.

Nodes installed using registry-install will cause issues due to the lack of assurance for those two aspects.

liusida commented 2 weeks ago

I thought everything is ready since @haohaocreates created two PRs for each one of my custom nodes. xD

ltdrdata commented 2 weeks ago

You can do pre-test via feat/cnr branch in ComfyUI-Manager.