Pirate ship 1.4.0 update

[Piratux]

All Submissions:

• [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Tested Changes:

1. [x] Have you lint your code (lua lint) locally prior to submission?

Changes to Core Features:

• [x] Have you added an explanation of what your changes do and why you'd like us to include them?
• [x] Have you successfully ran tests with your changes locally?

Comments

Changes:

Major:

• New island: Mysterious caves (added it to B and D island categories).
• Extra hold and power upgrades now can only be purchased at captain's cabin instead of docks.
• Car and nuclear fuel related technologies are now enabled.
• Players now can create private runs protected by a password. This run becomes public if the crew is empty or inactive for 24 hours (Limit is currently 1 private run at a time).
• Changed quest item count formula using new philosophy: start lower, scale slightly faster. This results in ~30% on average smaller requirement for items to open the market in early game. The reasoning: it was observed that new players rarely complete the market quest, since they don't make items as fast as needed. As well as when players progress, they can craft items much faster (due to speed modules).
• Changed static fuel consumption formula, which scales less aggressively with each additional crew member. For comparison, previously 3 and 6 crew members increased fuel consumption 2x and 3x respectively. Now 3 and 6 crew members increase fuel consumption by 1.24x and 1.44x respectively.

Minor:

• New market offers: logistic chests.
• Added science packs to labs in radioactive island.
• Fixed uranium-ammo pre-requisites.
• Cliff base now contains tank instead of car after 25 islands.
• Classes that generate ore now generate a constant amount (independent of crew size). Idea behind this is, that it's not fun being "punished" for having more members in your crew, as well as, with bigger crew you spend less time in islands.
• Lumberjack now gets ~4x more ore from chopping trees and ore amount scales with leagues to make it slightly more "relevant" in late game.
• Chests with cliff-explosives in holds now explode after 5 second delay.
• Changed the price of cliff explosives to cost 1000 coins for 5 (4x cheaper than before). Reasoning: This is an experiment to shift the coin spending meta.
• Players now can find explosives and cliff-explosives in chests in the wild.
• Reduced worm and spawner density in Poisonous Fens island. Reasoning: since this island is very big, there are naturally more biters there and it's a bit too dense with bigger crews.
• Reduced spawner density in Walkways island. Reasoning: in late game these islands become too hard, so this should help a bit.
• Reduced spawner density in Radioactive island. Reasoning: defending multiple structures can be difficult.
• Increased coal amounts in Frozen pools by 2x. Also amount now also scales with leagues.
• Added construction bots to findable roboport structure. Also robot amount scales with leagues and is slightly randomised.
• Sulfuric acid amount in Poisonous Fens now scales with leagues.
• Added loot to ship wrecks in Sandworm Caldera.
• Increased ore amount in Sandworm Caldera by 3x. Also amount now also scales with leagues.
• When crew loses, leagues achieved will be printed in discord as well.
• Radioactive island now has green water (as well as small green brightness that's only seen at night slightly).
• Reduced base amount of resource count quest item requirement by 10%.

Other:

• Made quest structures return random requirement item when raffle returns nil. This happens because some items have negative weights in lambda raffle.
• Moved island enum to its own file to avoid dependency loops.
• Standardised island enum usage to use IslandEnum.enum.
• Cleaned up code that checks for player's class and changed to get_class() where possible.
• Cleaned up code that checks if player is officer and changed to is_officer().
• Deprecated /setclass command (it was equivelant to /unlock + /take command as well as slightly outdated since class GUI was added).
• Changed message in radioactive island "2 [sulfuric barrels]" -> "Free resources granted for staying in this island. 2 [sulfuric barrels]".
• Added scroll pane for crews window.
• Fixed an issue where players could get artillery turret when buying the upgrade with full inventory.
• Fixed deprecated discord emojis.
• Fixed research tech unintentionally printing to discord when crew disbands.

[Gerkiz]

@danielmartin0 are these changes OK to merge? 🦖

[danielmartin0]

@danielmartin0 are these changes OK to merge? 🦖

Yep, happy to trust @Piratux's judgement. (I also don't have capacity to review atm)