Improve charging_station.lua (closes #451)

[vadcx]

https://github.com/ComfyFactory/ComfyFactorio/issues/451

Improve algorithmic complexity as proposed. The charging button now only iterates ONCE over entire inventory and ONCE over all nearby accumulators, breaking early if enough energy was supplied.

Add support for modded accumulators. The code will check maximum energy capacity of type=accumulator entities nearby for this to work.

Add code annotations.

Improve player-facing messages.

All Submissions:

• [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Tested Changes:

1. [ ] Have you lint your code (lua lint) locally prior to submission?

Changes to Core Features:

• [x] Have you added an explanation of what your changes do and why you'd like us to include them?
• [x] Have you successfully ran tests with your changes locally?

Comments

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[vadcx]

Silly bot, no recent activity doesn't mean the problem ceased to exist. I cannot reopen neither the issue nor the PR. I will keep pinging then.

[Quadrum1]

I agree, stalebot automatically closing tickets seems odd. Sadly, it seems I don't have the permissions to reopen this ticket.