CommandPost / CommandPost

Workflow Enhancements for Creatives
https://commandpost.io
MIT License
432 stars 37 forks source link

Bugs in "Reveal in Keyword Collection" #2098

Closed latenitefilms closed 5 years ago

latenitefilms commented 5 years ago

Iván de Paz writes:

Fantastic enhancement! From what I understand after some testing it only works with clips in the primary timeline and not with connected ones and it shows all the keywords from the whole clip, not from the selected part. It's easy and great being able to type and find the right keyword but would be even better if it would only appear the keywords from the concrete selection (like the ones that appear selected in the timeline index).

Little bug I got is that if you have a concrete keyword in different ranges of the same clip and you press "Reveal & Solo" it gets an error. Not a big problem because I see the bigger potential in "Reveal in Keyword Collection" but little bug anyway. Thank you so much Chris Hocking and for your amazing work🙂

latenitefilms commented 5 years ago

What went wrong? Error after “Reveal in Keyword Collection & Solo” a keyword that is more than one time in the same clip.

What did you expect to happen? I suppose it should show all the ranges with that keyword in the same clip. Anyway I think that the “Solo” action is not really necesary as the selection is alrealy highlighted with the “Reveal in Keyword Collection” action.

What are the steps to recreate the problem? mark a single clip with the same keyword in more than one range. Select the clip in the timeline and do the “Reveal Keyword Collection & Solo” action.

Console Output:

CommandPost v1.0.0-beta.89 (Build: 5674)

Build Date: � � � � � � � � � � Nov� 2 2019, 00:52:41
macOS Version:� � � � � � � � � 10.14.5
CommandPost Locale: � � � � � � en
Current Keyboard Layout:� � � � Spanish - ISO
Final Cut Pro Path: � � � � � � /Applications/Final Cut Pro.app
Final Cut Pro Version:� � � � � 10.4.6
Final Cut Pro Language: � � � � en
Developer Mode: � � � � � � � � false

2019-11-01 18:37:29: 2019-11-01 18:37:28: -- Loading /Users/ivan/Applications/CommandPost.app/Contents/Resources/extensions/cp/init.lua
2019-11-01 18:37:28: -- Loading extension: hs.uielement
2019-11-01 18:37:29: 18:37:29 � � � � cp: � � Loading Plugins...
2019-11-01 18:37:30: 18:37:30 ** Warning: � plugins: Slow Plugin: finalcutpro.pasteboard.shared (0.110865)
2019-11-01 18:37:30: 18:37:30 ** Warning: � plugins: Slow Plugin: finalcutpro.tangent.info (0.121773)
2019-11-01 18:37:30: 18:37:30 ** Warning: � plugins: Slow Plugin: finalcutpro.tangent.video (0.135181)
2019-11-01 18:37:44: ********
2019-11-01 18:37:44: 18:37:44 ERROR:� � � scan: Failed to cache User Effects Presets.
2019-11-01 18:37:44: ********
2019-11-01 18:37:46: 18:37:46 ** Warning: � plugins: Slow Plugin: finalcutpro.setup.scan (1.711387)
2019-11-01 18:37:46:� � � � � � � � � cp: � � Plugins Loaded.
2019-11-01 18:37:46:� � � � � � � � � � � � � Startup Time: 4.008309 seconds
2019-11-01 18:37:46: -- Done.
2019-11-01 18:41:45: ********
2019-11-01 18:41:45: 18:41:45 ERROR:� � fcpBug: Javascript Error: {
� code = 4,
� domain = "WKErrorDomain",
� localizedDescription = "A JavaScript exception occurred"
}
2019-11-01 18:41:45: ********
2019-11-01 18:46:16: ********
2019-11-01 18:46:16: 18:46:16 ERROR: � LuaSkin: hs.webview.usercontent callback: ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: attempt to index a nil value (field '?')
stack traceback:
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: in upvalue 'process'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:539: in upvalue 'find'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:706: in function <...Resources/plugins/finalcutpro/hud/panels/search/init.lua:699>
    (...tail calls...)
2019-11-01 18:46:16: ********
2019-11-01 18:46:31: ********
2019-11-01 18:46:31: 18:46:31 ERROR: � LuaSkin: hs.webview.usercontent callback: ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: attempt to index a nil value (field '?')
stack traceback:
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: in upvalue 'process'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:539: in upvalue 'find'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:706: in function <...Resources/plugins/finalcutpro/hud/panels/search/init.lua:699>
    (...tail calls...)
2019-11-01 18:46:31: ********
2019-11-01 18:50:22: ********
2019-11-01 18:50:22: 18:50:22 ERROR: � LuaSkin: hs.webview:navigationCallback() didFinishNavigation callback error: ...tents/Resources/extensions/cp/apple/finalcutpro/init.lua:446: attempt to index a nil value (local 'self')
stack traceback:
    ...tents/Resources/extensions/cp/apple/finalcutpro/init.lua:446: in field 'activeLibraryPaths'
    .../Resources/plugins/finalcutpro/hud/panels/notes/init.lua:76: in field 'loadedFn'
    ...tents/Resources/plugins/finalcutpro/hud/manager/init.lua:468: in function <...tents/Resources/plugins/finalcutpro/hud/manager/init.lua:460>
2019-11-01 18:50:22: ********
2019-11-01 18:51:27: ********
2019-11-01 18:51:27: 18:51:27 ERROR: � LuaSkin: hs.webview:navigationCallback() didFinishNavigation callback error: ...tents/Resources/extensions/cp/apple/finalcutpro/init.lua:446: attempt to index a nil value (local 'self')
stack traceback:
    ...tents/Resources/extensions/cp/apple/finalcutpro/init.lua:446: in field 'activeLibraryPaths'
    .../Resources/plugins/finalcutpro/hud/panels/notes/init.lua:76: in field 'loadedFn'
    ...tents/Resources/plugins/finalcutpro/hud/manager/init.lua:468: in function <...tents/Resources/plugins/finalcutpro/hud/manager/init.lua:460>
2019-11-01 18:51:27: ********
2019-11-01 18:52:00: ********
2019-11-01 18:52:00: 18:52:00 ERROR: � LuaSkin: hs.webview:navigationCallback() didFinishNavigation callback error: ...tents/Resources/extensions/cp/apple/finalcutpro/init.lua:446: attempt to index a nil value (local 'self')
stack traceback:
    ...tents/Resources/extensions/cp/apple/finalcutpro/init.lua:446: in field 'activeLibraryPaths'
    .../Resources/plugins/finalcutpro/hud/panels/notes/init.lua:76: in field 'loadedFn'
    ...tents/Resources/plugins/finalcutpro/hud/manager/init.lua:468: in function <...tents/Resources/plugins/finalcutpro/hud/manager/init.lua:460>
2019-11-01 18:52:00: ********
2019-11-01 19:13:03: ********
2019-11-01 19:13:03: 19:13:03 ERROR: � LuaSkin: hs.webview.usercontent callback: ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:295: attempt to index a nil value (field '?')
stack traceback:
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:295: in upvalue 'process'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:539: in upvalue 'find'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:706: in function <...Resources/plugins/finalcutpro/hud/panels/search/init.lua:699>
    (...tail calls...)
2019-11-01 19:13:03: ********
2019-11-01 19:13:10: ********
2019-11-01 19:13:10: 19:13:10 ERROR: � LuaSkin: hs.webview.usercontent callback: ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: attempt to index a nil value (field '?')
stack traceback:
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: in upvalue 'process'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:539: in upvalue 'find'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:706: in function <...Resources/plugins/finalcutpro/hud/panels/search/init.lua:699>
    (...tail calls...)
2019-11-01 19:13:10: ********
2019-11-01 19:13:12: ********
2019-11-01 19:13:12: 19:13:12 ERROR: � LuaSkin: hs.webview.usercontent callback: ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: attempt to index a nil value (field '?')
stack traceback:
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: in upvalue 'process'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:539: in upvalue 'find'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:706: in function <...Resources/plugins/finalcutpro/hud/panels/search/init.lua:699>
    (...tail calls...)
2019-11-01 19:13:12: ********
2019-11-01 19:13:16: ********
2019-11-01 19:13:16: 19:13:16 ERROR: � LuaSkin: hs.webview.usercontent callback: ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:295: attempt to index a nil value (field '?')
stack traceback:
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:295: in upvalue 'process'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:539: in upvalue 'find'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:706: in function <...Resources/plugins/finalcutpro/hud/panels/search/init.lua:699>
    (...tail calls...)
2019-11-01 19:13:16: ********
2019-11-01 19:13:20: ********
2019-11-01 19:13:20: 19:13:20 ERROR: � LuaSkin: hs.webview.usercontent callback: ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:295: attempt to index a nil value (field '?')
stack traceback:
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:295: in upvalue 'process'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:539: in upvalue 'find'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:706: in function <...Resources/plugins/finalcutpro/hud/panels/search/init.lua:699>
    (...tail calls...)
2019-11-01 19:13:20: ********
2019-11-01 19:13:23: ********
2019-11-01 19:13:23: 19:13:23 ERROR: � LuaSkin: hs.webview.usercontent callback: ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: attempt to index a nil value (field '?')
stack traceback:
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: in upvalue 'process'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:539: in upvalue 'find'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:704: in function <...Resources/plugins/finalcutpro/hud/panels/search/init.lua:699>
    (...tail calls...)
2019-11-01 19:13:23: ********
2019-11-01 19:13:26: ********
2019-11-01 19:13:26: 19:13:26 ERROR: � LuaSkin: hs.webview.usercontent callback: ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:295: attempt to index a nil value (field '?')
stack traceback:
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:295: in upvalue 'process'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:539: in upvalue 'find'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:704: in function <...Resources/plugins/finalcutpro/hud/panels/search/init.lua:699>
    (...tail calls...)
2019-11-01 19:13:26: ********
2019-11-01 19:13:30: ********
2019-11-01 19:13:30: 19:13:30 ERROR: � LuaSkin: hs.webview.usercontent callback: ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: attempt to index a nil value (field '?')
stack traceback:
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:294: in upvalue 'process'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:539: in upvalue 'find'
    ...Resources/plugins/finalcutpro/hud/panels/search/init.lua:706: in function <...Resources/plugins/finalcutpro/hud/panels/search/init.lua:699>
    (...tail calls...)
2019-11-01 19:13:30: ********
2019-11-01 19:14:10: ********
2019-11-01 19:14:10: 19:14:10 ERROR: hudButton: showColumn: Failed to activate the columns menu popup when restoring column data.
2019-11-01 19:14:10: ********
2019-11-01 19:22:48: ********
2019-11-01 19:22:48: 19:22:48 ERROR:� � dialog: Error Message Displayed: Expected exactly 1 selected clip in the Libraries Browser.

Error occurred in soloClip().
2019-11-01 19:22:48: ********
2019-11-01 20:18:22: ********
2019-11-01 20:18:22: 20:18:22 ERROR: � LuaSkin: hs.timer callback error: ...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:409: attempt to get length of a nil value (local 'containedItems')
stack traceback:
    ...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:409: in function <...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:400>
    (...tail calls...)
    ...tents/Resources/plugins/finalcutpro/commands/actions.lua:135: in upvalue 'successFn'
    ...t.app/Contents/Resources/extensions/cp/commands/init.lua:312: in upvalue 'actionFn'
    ...Post.app/Contents/Resources/extensions/hs/timer/init.lua:121: in function <...Post.app/Contents/Resources/extensions/hs/timer/init.lua:118>
2019-11-01 20:18:22: ********
2019-11-01 21:03:19: ********
2019-11-01 21:03:19: 21:03:19 ERROR: � clipmgr: Failed to select Copy from Menubar. Error occurred in plugins.finalcutpro.pasteboard.manager.ninjaPasteboardCopy().
2019-11-01 21:03:19: ********
2019-11-01 21:03:26: ********
2019-11-01 21:03:26: 21:03:26 ERROR: � LuaSkin: hs.timer callback error: ...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:409: attempt to get length of a nil value (local 'containedItems')
stack traceback:
    ...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:409: in function <...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:400>
    (...tail calls...)
    ...tents/Resources/plugins/finalcutpro/commands/actions.lua:135: in upvalue 'successFn'
    ...t.app/Contents/Resources/extensions/cp/commands/init.lua:312: in upvalue 'actionFn'
    ...Post.app/Contents/Resources/extensions/hs/timer/init.lua:121: in function <...Post.app/Contents/Resources/extensions/hs/timer/init.lua:118>
2019-11-01 21:03:26: ********
2019-11-01 21:03:28: ********
2019-11-01 21:03:28: 21:03:28 ERROR: � LuaSkin: hs.timer callback error: ...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:409: attempt to get length of a nil value (local 'containedItems')
stack traceback:
    ...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:409: in function <...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:400>
    (...tail calls...)
    ...tents/Resources/plugins/finalcutpro/commands/actions.lua:135: in upvalue 'successFn'
    ...t.app/Contents/Resources/extensions/cp/commands/init.lua:312: in upvalue 'actionFn'
    ...Post.app/Contents/Resources/extensions/hs/timer/init.lua:121: in function <...Post.app/Contents/Resources/extensions/hs/timer/init.lua:118>
2019-11-01 21:03:28: ********
2019-11-01 21:03:29: ********
2019-11-01 21:03:29: 21:03:29 ERROR: � LuaSkin: hs.timer callback error: ...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:409: attempt to get length of a nil value (local 'containedItems')
stack traceback:
    ...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:409: in function <...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:400>
    (...tail calls...)
    ...tents/Resources/plugins/finalcutpro/commands/actions.lua:135: in upvalue 'successFn'
    ...t.app/Contents/Resources/extensions/cp/commands/init.lua:312: in upvalue 'actionFn'
    ...Post.app/Contents/Resources/extensions/hs/timer/init.lua:121: in function <...Post.app/Contents/Resources/extensions/hs/timer/init.lua:118>
2019-11-01 21:03:29: ********
2019-11-01 21:03:29: ********
2019-11-01 21:03:29: 21:03:29 ERROR: � LuaSkin: hs.timer callback error: ...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:409: attempt to get length of a nil value (local 'containedItems')
stack traceback:
    ...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:409: in function <...ts/Resources/plugins/finalcutpro/timeline/matchframe.lua:400>
    (...tail calls...)
    ...tents/Resources/plugins/finalcutpro/commands/actions.lua:135: in upvalue 'successFn'
    ...t.app/Contents/Resources/extensions/cp/commands/init.lua:312: in upvalue 'actionFn'
    ...Post.app/Contents/Resources/extensions/hs/timer/init.lua:121: in function <...Post.app/Contents/Resources/extensions/hs/timer/init.lua:118>
2019-11-01 21:03:29: ********
2019-11-01 22:53:41: ********
2019-11-01 22:53:41: 22:53:41 ERROR: � clipmgr: Failed to select Copy from Menubar. Error occurred in plugins.finalcutpro.pasteboard.manager.ninjaPasteboardCopy().
2019-11-01 22:53:41: ********
2019-11-01 22:53:54: ********
2019-11-01 22:53:54: 22:53:54 ERROR:� � dialog: Error Message Displayed: Expected exactly 1 selected clip in the Libraries Browser.

Error occurred in soloClip().
2019-11-01 22:53:54: ********