search

CommanderCoder / beebem-mac

BBC micro emulator for Apple Mac
https://www.commandercoder.com/beebem-mac/
Other
2 stars 0 forks source link

65C02 second processor setting not effective in Preferences (fix available) #2

Open peterthegrey opened 2 months ago

peterthegrey commented 2 months ago

I have not cross checked with performance of the PC version in this regard..... In Beta 4, From the hardware menu selections: Econet setting is recorded in preferences SCSI drive setting is recorded, as is the Hard disc folder setting Floppy drive setting is recorded Sideways rom inserted/unplugged settings (which I think may be in CMOS) is recorded.

but the selection of a second processor is not recorded.

--EDIT-- I have tried to read the source code, and did a couple of tests. I see that there is an entry "TubeType" in preferences, and that if this entry is 1 then it should indicate that the Acorn65C02 second processor is selected.

So the problem is better stated as "second process not being reselected from Prefs file on restart" or something like that.

chrisn commented 2 months ago

This is a bug in Windows BeebEm, fixed in https://github.com/stardot/beebem-windows/commit/98ce22d93ae882f9cf41f509a0a37ed560b86ffe.

peterthegrey commented 2 months ago

I have tried the fix reported by chrisn above and confirm that it works. Xcode 15.4 on my macOS 14.5 M1 iMac.

Line 1635 of BeebWinPrefs.cc changes to

m_Preferences.SetStringValue(CFG_TUBE_TYPE, TubeDeviceStr[(int)TubeType]);