search

CommanderRoot / twitch-tools

A feedback / feature request repo for https://twitch-tools.rootonline.de/
27 stars 0 forks source link

[Bug] Loading blocks stalls when having a very large existing blocklist #98

Open foehammer88 opened 2 months ago

foehammer88 commented 2 months ago

I've been running Blocklist manager for maybe over a month now, continuously blocking known bots. It started around 24m known bots it was going to block, and slowly dwindled down, then I had to restart my machine a couple times, so the known bots grew a little bit after it already dwindled down.

When I got to around ~9m known bots left to block yesterday or the day before, it started blocking the bots incredibly slowly. It has done this in the past and I simply refreshed and it was all good. This time I refreshed, and whilst loading blocks, it has stalled at 16,777,198 blocks loaded. I'm wondering if the browser has run out of memory for the page, after loading that many blocks.

I've tried this on Safari and Chrome and both stall out around that number, maybe the same number. I tried clicking (abort) but nothing happens. It just still shows: "Loading blocks ... 16,777,198 (abort)", and no way to go to continue to the block manager UI to add more known bot blocks or apply filters.

My Macbook Pro 15" Late 2019 has 64 GB of memory and it's not filled up. I haven't tried Firefox yet, but I can try that next.

Would like to continue blocking all known bot accounts, and once I get to the end of the list, run it like once a week to block the newly identified bot accounts discovered each week.

CommanderRoot commented 2 months ago

This issue is similar to #5. With these kind of numbers it's quite possible that you're hitting some kind of browser memory (not even PC memory but just "this variable can't be bigger than 2 GB") or execution time limit. I don't use a Macbook so I have no idea how Safari behaves. As for Chrome vs Firefox, Firefox is way better when it comes to lots of accounts. You might want to give that a try. Ultimately there is a limit on what you can do within a browser through and since Twitch doesn't really suspend these bot accounts, the known bot list gets bigger and bigger. Using the "block all new followers" tool with the setting set to "known bots" might be better as that would only block the accounts when they actually follow

foehammer88 commented 1 month ago

Thanks for the info. Firefox worked for me to load my entire blocklist and continue with the blocking of known bot accounts, although I decided not to continue running the blocks not long afterwards.

I used the feature you linked to, but I didn't know how to use the page and just logged in and didnt change anything, figuring I would come back to it later to learn more about that feature. But I left it like that for a week, and noticed that all new followers unfollowed, and it wasn't until two followers spoke up and we figured out it was automatically blocking them then they followed, but they could still type in chat but couldn't view my stream.

I figured out it was that feature that was defaulted to "Block All New Followers", so I quickly removed that connection in Twitch Settings, and the very patient viewer was able to follow me and I follow him without the follower status being removed.

After discovering that blocking a user account on Twitch only prevents them from following and viewing your stream, and doesn't prevent them from chatting, I decided to not continue with the "Block all Known Followers" process, and not continue with blocking all known bot followers.

My recommendation from the "Block All New Followers" feature, is to not default it to "Block All New Followers" setting, because as soon as you click the "Login via Twitch" button and authorize via Twitch, it will automatically block all new followers, even if they are real users, before you do anything.

I would suggest having the setting option and then a confirm button or default it to "Block all new known Bot followers" or something not as destructive as the default "Block All New Followers".

And what I really would like is to ban known bot accounts from Chat to prevent the "Cheap/Best viewers..." spam, instead of blocking bots from following or viewing the stream.

CommanderRoot commented 1 month ago

Thank you for your feedback in regards to the "Block all new followers" tool.

As for the chat bans. I don't monitor chat at all so I'm not sure if the same accounts that are used for follow botting are also used for that. It's possible that these are different people with different accounts.