search

Commentative / commentative

Add your thoughts when sharing content
https://commentative.herokuapp.com/
GNU General Public License v3.0
5 stars 1 forks source link

implement comment ui from prototype #30

Open reubengt opened 4 years ago

reubengt commented 4 years ago

there is some ui work to be done to the comment box, the prototype has a minimized version, a popup with an input, and a final state where the comments for the selected paragraph are displayed one by one, with two arrows to navigate through them.

also, presently there is no way of entering a name. should this be done alongside the comment(maybe for the first comment you post?) im not a ux person haha

@samstephenson would appreciate any insight on when the user should enter their name.

mbanerjeepalmer commented 4 years ago

For reference, Sam's initial Figma (which is in the Wiki): https://www.figma.com/proto/khs6bCrKkWeTLsmzmFcWuj/Commentative-prototype?node-id=1%3A955&viewport=129%2C120%2C0.3731025755405426&scaling=scale-down

reubengt commented 4 years ago

having a minimized version of the comment box is unnecessarily complex. to code this i would have to listen for the text input being clicked, then change the look of a few elements and pull a button into view.

having a textbox and a button there, but of a small height, which expand in size as the user types is a more seamless ui than elements disappearing when the user tries to type imo.

implemented the arrow navigation just now, when there are two or more comments they dont stack, you can navigate between them using two arrow buttons on the comment display.

still unsure what the best place is for the user to enter a name. thoughts?

samstephenson commented 4 years ago

Added a quick way to enter your name: https://www.figma.com/file/khs6bCrKkWeTLsmzmFcWuj/Commentative-prototype?node-id=67%3A8

Explainer video: https://www.loom.com/share/9f982a7a2ded4e808c01bab620bf527f