search

Commentative / commentative

Add your thoughts when sharing content
https://commentative.herokuapp.com/
GNU General Public License v3.0
5 stars 1 forks source link

Fix/uniquelink #37

Closed reubengt closed 4 years ago

reubengt commented 4 years ago

branched off #34 so merge that first.

reloading the uuid url now works, and loads comments as well except for one bug #36 fixed invite button.

the invite button now copies the invite link to the clipboard and shows a success popup.

reubengt commented 4 years ago

Yep that's definitely going to change,just put that in for the sake of having something there(it was a pen emoji before) I'm still unsure what the best place to prompt the user for a name is.

reubengt commented 4 years ago

Clipboard library was for browser support tbh, async clipboard api is fairly new, and document.execCommand("copy") requires text to be selected. In our case we don't really have text, the button has an attribute which has the link as its value.

Saw a couple hacky solutions to temporarily append a textarea to the dom, copy text from it, then delete it.

Seemed unnecessary. I'll check again if there's an easier way to implement this for out specific use case(button to copy the current url to clipboard)