search

CommerceDataService / DataService_WebSite

The website for the Commerce Data Service - A startup within the Department of Commerce
https://www.commerce.gov/dataservice
2 stars 8 forks source link

Changes to landing panel #59

Closed radhikabhatt26 closed 8 years ago

maabrown commented 8 years ago

Hola. I have a couple of questions:

  1. Why did you bring the parallax.js file back into index.html? The parallax works without it so we don't need it.
  2. I re-named the CSS file because since have numerous CSS style sheets (CDS Dasbhoard, general CDS site, MixItUp) - a file called "CDSCustom.css" tells me nothing about which one I'm using and I was personally finding it hard to keep track of which CSS style sheet I was looking at.
arowla commented 8 years ago

@maabrown I was working with @radhikabhatt26 today to try and figure out how those changes got reverted. Looking now like maybe it was just an older version of the file open in an editor. We'll need to revert those parts of the commit. I'll send a PR to @radhikabhatt26 's feature branch.