search

CommerceDataService / ITA_Principal_Travel

1 stars 10 forks source link

Created template tag to maintain url query params in pagination #214

Closed neka-io closed 8 years ago

neka-io commented 8 years ago

fixes #208

codecov-io commented 8 years ago

Current coverage is 34.36%

Merging #214 into develop will increase coverage by 1.62%

@@            develop       #214   diff @@
==========================================
  Files             9         10     +1   
  Lines           443        454    +11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            145        156    +11   
  Misses          298        298          
  Partials          0          0

Powered by Codecov. Last updated by 384c52d...3887ab1

arowla commented 8 years ago

Has this been tested? I started writing a test and the output was not as I expected, since Django's HttpRequest.urlencode() only returns query parameters.

neka-io commented 8 years ago

Are you also passing the page parameter to the template tag? I'm passing the page key value pair from the template and the other query strings come from the urlencode()

arowla commented 8 years ago

Oh I see now... the intent is to create relative links with only the GET parameters. I haven't seen that done before, but apparently it is valid. I'm updating my test to reflect that.