search

CommerceDataService / ITA_Principal_Travel

1 stars 10 forks source link

added bottom padding to each page #235

Closed radhikabhatt26 closed 8 years ago

codecov-io commented 8 years ago

Current coverage is 65.18%

Merging #235 into develop will not change coverage

@@            develop       #235   diff @@
==========================================
  Files            12         12          
  Lines           586        586          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            382        382          
  Misses          204        204          
  Partials          0          0

Powered by Codecov. Last updated by 105dc86...5b339c7

arowla commented 8 years ago

Hi @radhikabhatt26 , the original fix for this didn't require adding something to each page-- and I see that my original fix in the CSS is now commented out as a result of the commit below. Is there any way we can get back to a more universal fix?

https://github.com/radhikabhatt26/ITA_Principal_Travel/commit/dcda4bcc08d83eb0f1f250506a5964db7d406666#diff-c7c46c788a7fb0f0e5bbcf03d476b5af

Under this fix, won't every new page need a special class added just to not overlap the footer? cc@nkalbasi

radhikabhatt26 commented 8 years ago

@arowla I reverted back to the universal fix and fixed the white space issue.

arowla commented 8 years ago

Thank you!