Create Commitment: set distance goal

[spengrah]

User Story / Job to be Done / Problem As a user creating a new commitment, I want to set a distance goal for my selected activity

Potential solution ideas

• number field
• validate against commitment type max/min (if relevant)

Additional context

• should be aware of units (e.g. km vs. miles) #30

[bitbeckers]

Question on the max/min. Where do we feel we could/should have any? It's value should be >0, but can we determine a max? For exampe if I'd like to run 150 miles in a month it could be fine, in a week you're like a top 1% ultrarunner

[bitbeckers]

https://github.com/bitbeckers/commitpool-ui-bare/pull/1

[spengrah]

Question on the max/min. Where do we feel we could/should have any? It's value should be >0, but can we determine a max? For exampe if I'd like to run 150 miles in a month it could be fine, in a week you're like a top 1% ultrarunner

Probably don't need a max, but I think a min will often apply. But this should be driven by whatever max and min are in the contract for the given commitment type.

[bitbeckers]

If that is the case, for now we should be sure that the contract does not alow values <0, but a uint can not be negative right? And for review, double check the km/mi conversion and what is in Strava, I need to check this as well

[spengrah]

but a uint can not be negative right? correct

[bitbeckers]

Same as with stake amount, we could display a text like "That's far! Are you maybe... Invincible?!" (dunno, we need Rapunzel for this) to alert the user on high activity distances? And that's all we do for now?

[bitbeckers]

The distance is now set in miles, since that's what we have now in the app and I need some more info before we can do the distance unit of measurement magic