Fix/loading screen after login

[gitguardian[bot]]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [12247943](https://dashboard.gitguardian.com/workspace/520314/incidents/12247943) | Triggered | Generic High Entropy Secret | e700fbbfe539139a0a09af398eac459280b4f15e | app/firebase/functions/test/__tests__/user.timeline.result.mock.json | [View secret](https://github.com/Common-SenseMakers/sensemakers/commit/e700fbbfe539139a0a09af398eac459280b4f15e#diff-d32120182dda07ea5bd30d3ecc8023e8cb607a4f3891a087a7d3fe9153199e26L1340) | | [12247944](https://dashboard.gitguardian.com/workspace/520314/incidents/12247944) | Triggered | Generic High Entropy Secret | 1ebf60d331ab830fbd6775ae569e090b61b57dca | app/firebase/functions/test/__tests__/user.timeline.result.mock.json | [View secret](https://github.com/Common-SenseMakers/sensemakers/commit/1ebf60d331ab830fbd6775ae569e090b61b57dca#diff-d32120182dda07ea5bd30d3ecc8023e8cb607a4f3891a087a7d3fe9153199e26R1444) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[weswalla]

@pepoospina overall this abstraction is easier for me to work with, though it seems there are some redundancies with connectedUser and LoginStatus.LoggedIn (not quite because the connected user is the user object). It also get's more challenging to evaluate the abstraction when thinking about supporting 'login' with different platforms, though I think it does cover those cases.

[pepoospina]

@weswalla we can merge this, it seems reasonable. But I tried running the tests and got some errors:

  1) 030-process
       create and process
         "before all" hook for "publish a tweet in the name of the test user":
     Error: user not created
      at _01_createAndFetchUsers (test/__tests__/reusable/create-post-fetch.ts:45:20)
      at async Context.<anonymous> (test/__tests__/030-post.publish.test.ts:51:14)

  2) 050-autofetch-no-autopost
       create and process
         "before all" hook for "upates user autopost settings":
     Error: user not created
      at _01_createAndFetchUsers (test/__tests__/reusable/create-post-fetch.ts:45:20)
      at async Context.<anonymous> (test/__tests__/050-post.autofetch-noautopost.test.ts:51:14)

  3) 051-autofetch-autopost
       create and process
         "before all" hook for "upates user autopost settings":
     Error: user not created
      at _01_createAndFetchUsers (test/__tests__/reusable/create-post-fetch.ts:45:20)
      at async Context.<anonymous> (test/__tests__/051-post.autofetch-autopost.test.ts:55:14)

  4) 060-send-digest-no-autpost
       create and process
         "before all" hook for "upates user autopost settings":
     Error: user not created
      at _01_createAndFetchUsers (test/__tests__/reusable/create-post-fetch.ts:45:20)
      at async Context.<anonymous> (test/__tests__/060-notifications.send-digest.test.ts:49:14)

Are they running on your side? Maybe we need some change on the env files?

[weswalla]

@pepoospina I believe its the TEST_USER_ACCOUNTS they now need an id: https://discord.com/channels/1001036228294094909/1255286821672190002/1255288519757135955