[APP] handle read and write twitter access tokens separately

Common-SenseMakers / sensemakers

Sensemakers infrastructure for developing AI-based tools for semantic annotations of social posts. Cross-poster app to publish your semantic posts on different networks.

GNU General Public License v3.0

1 stars 2 forks source link

[APP] handle read and write twitter access tokens separately #55

Open weswalla opened 4 months ago

weswalla commented 4 months ago

currently we handle read and write twitter access tokens together. https://github.com/Common-SenseMakers/sensemakers/blob/081c8baed49d16f00fdc1007bf4d47402e50de26/app/firebase/functions/src/platforms/twitter/twitter.service.ts#L356-L360 https://github.com/Common-SenseMakers/sensemakers/pull/35/commits/00963c00f71ad2acf77b8deae312e1722f083355

Though this doesn't properly handle the case of revoking write access, since they are the same token. Ideally, we should handle these separately.

pepoospina commented 4 months ago

I'm not sure if we should keep this issue open @weswalla.

Handling independent granting and revoking of read and write credentials seems complicated. It maybe impossible from a Twitter API point of view, which might force one access grant per app id.

We would then need logic both on the frontend and the backend to manage these two flows, for granting and revoking, and UX analysis for it to be clear.

I suggest we close this issue for now