search

CommonBike / commonbike-site

Meteor Javascript site for CommonBike
https://common.bike
7 stars 9 forks source link

Merge pve's Travis config into CommonBike repository #104

Closed bartwr closed 6 years ago

bartwr commented 6 years ago

This PR makes it possible to test and deploy with confidence, using Travis CI.

Thanks to @pve for this initiative. After merging we can autodeploy using Heroku & Travis combined.

pve commented 6 years ago

you merged pve:master, but maybe you should merge from pve:develop I will have to figure that out by testing. Beyond that, it would be good to discuss how to deploy an automatic acceptance test environment from this.

bartwr commented 6 years ago

you merged pve:master, but maybe you should merge from pve:develop. I will have to figure that out by testing.

I merged your master and not develop, because only the master contains the .travis.yml file :)

Beyond that, it would be good to discuss how to deploy an automatic acceptance test environment from this.

Good topic for a next meeting indeed. You proposed this on Slack as well - we'll make this reality in the near future.

@pve

pve commented 6 years ago

Yeah, it is all kind of rusty after a few months. Will have to look into it. Let me try to trigger Travis off the master branch, this is supposed to require you to accept certain permissions on github. Will let you know. I am actually having a few days off, but this is fun enough to get started. We might need an acceptance feature branch or something, to trigger these tests.

Will get back soon.

2017-11-13 13:57 GMT+01:00 bartwr notifications@github.com:

you merged pve:master, but maybe you should merge from pve:develop. I will have to figure that out by testing.

I merged your master https://github.com/pve/commonbike-site-2/tree/master and not develop https://github.com/pve/commonbike-site-2/tree/develop, because only the master contains the .travis.yml file :)

Beyond that, it would be good to discuss how to deploy an automatic acceptance test environment from this.

Good topic for a next meeting https://www.meetup.com/commonbike/ indeed. You proposed this on Slack http://slack.common.bike/ as well - we'll make this reality in the near future.

@pve https://github.com/pve

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CommonBike/commonbike-site/pull/104#issuecomment-343910971, or mute the thread https://github.com/notifications/unsubscribe-auth/AACQ_NZ8TKYHM_mga3g9cfZ1UWRPvvExks5s2DyogaJpZM4Qa-Mz .

-- Peter HJ van Eijk | +31 6 2268 4939 | peter@clubcloudcomputing.com| Twitter @petersgriddle | www.clubcloudcomputing.com Schedule a call with me: https://www.canumeet.com/peter/30-minute-meeting