CommonBuildToolset / CBT.Modules

Modules for CBT
MIT License
9 stars 5 forks source link

Move the OutDir redirection logic to Before.Microsoft.Common.targets #257

Closed SamAtMicrosoft closed 5 years ago

SamAtMicrosoft commented 5 years ago

This allows the user to override settings based on what's in the project file. Speficially, it lets us use the AssemblyName.

Add a new flag: CBTUnifiedOutputDirUseAssemblyName. When set to true, uses AssemblyName as the CBTRelativeOutputPathAppend. This is specified as a boolean to allows the user to set CBTUnifiedOutputDirUseAssemblyName to true in the directory.build.props before the AssemblyName is known.

kingerja commented 5 years ago

We have largely abandoned this module as redirecting outputs has proven to be realistically impossible given all the various hardcoded assumptions and property misuses when you consider (VS, nuget, c# targets, c++ targets, web projects, ...)

I will sync with jeff to see if we want to keep the source here and let the community do as they want with it or if we just want to remove this module from here.