CommonCoreOntology / CommonCoreOntologies

The Common Core Ontology Repository holds the current released version of the Common Core Ontology suite.
Other
163 stars 47 forks source link

Suggested change for Best Practices doc #24

Open cmungall opened 5 years ago

cmungall commented 5 years ago

Principle of Single Inheritance:

_This principle does not prohibit the use of subclass or equivalent class axioms whereby a class is defined to be a subclass or equivalent class of an anonymous class. The OWL language provides the means to express facts about entities using relations to other entities. For example, a fact such as “Automobile has_part some Engine” uses the haspart relation to relate each automobile to at least one engine. The semantics of this fact is that Automobile has been made a subclass of the anonymous class “thing having at least one engine as part”. The class is anonymous because it is not part of the asserted taxonomy. The set of subclass and equivalent class axioms forms the inferred taxonomy of an ontology. In this inferred taxonomy classes previously anonymous become explicit and the principle of single inheritance is no longer in force. For further details see: (Smith & Ceusters, 2010)

This is a little confusing as it confuses assertion with namedClass v classExpression distinction.

If I assert "car SubClassOf has_part some engine" it's still an assertion, not inferred.

I think what you want to say is:

  1. Ontology editors should only assert one named superclass
  2. The inferred/released edition of the ontology may have multiple direct inferred superclasses. This will be especially common with compositional classes which form a lattice/polyhierarchy on reasoning

Note that I think 1 is a good engineering rule of thumb but would not elevate to a principle.

johnbeve commented 7 months ago

@mark-jensen @APCox @cmungall is right; that this passage is misleading.

Are there plans to revise the Best Practices document?

cameronmore commented 7 months ago

There are no current plans to update this document, but I'm happy to write a new version with collaborators, and will keep it in mind on further documentation.

mark-jensen commented 7 months ago

@cameronmore Why wouldn't we update the existing document rather than go through the effort of drafting an entirely new one?

Please create a wiki page for recording needed changes, fixes, improvements, etc. for the current or next Best Practices doc. Make sure to add a link to this issue and any others that may be relevant to improving the doc. Also add the link to the wiki page in a comment here.

This issue should stay open until we decide whether to create a new one vs. update the existing one.