CommonGarden / Grow-IoT

Software packages for smart growing environments.
http://commongarden.org/
Other
25 stars 6 forks source link

things by type #293

Closed aruntk closed 7 years ago

aruntk commented 7 years ago

User Story

example:

node tests/test-device.js 6e42b6d8-1c3b-4a69-9527-4b8d20f8486c nLoyuaKpuMG4nCZTYfuRHQtoMFKPbb2j temperature

Tasks

What's this PR do? List the related issues also

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots (if appropriate)

Questions:

JakeHartnell commented 7 years ago

Thanks! This was really helpful. This is more along the lines of what I was thinking of: https://github.com/CommonGarden/Grow-IoT/commit/c1abbd66adc6735396acd4dc9f645e30ea2b8249

See thing-display.html and thing-display.js.

aruntk commented 7 years ago

@JakeHartnell What about taking uuid and token as arguments from command in tests/test-device.js.? https://github.com/CommonGarden/Grow-IoT/blob/f61d62b396b85f6c160cf174e8dda20b14794483/tests/test-device.js . Isn't it is better than copy pasting uuid&token every time someone wants to start testing?

JakeHartnell commented 7 years ago

@JakeHartnell What about taking uuid and token as arguments from command in tests/test-device.js.? https://github.com/CommonGarden/Grow-IoT/blob/f61d62b396b85f6c160cf174e8dda20b14794483/tests/test-device.js . Isn't it is better than copy pasting uuid&token every time someone wants to start testing?

Good idea. We need better testing infrastructure...

aruntk commented 7 years ago

@JakeHartnell A start https://github.com/CommonGarden/Grow-IoT/tree/arun-tests.