Closed aruntk closed 7 years ago
Thanks! This was really helpful. This is more along the lines of what I was thinking of: https://github.com/CommonGarden/Grow-IoT/commit/c1abbd66adc6735396acd4dc9f645e30ea2b8249
See thing-display.html
and thing-display.js
.
@JakeHartnell What about taking uuid and token as arguments from command in tests/test-device.js.? https://github.com/CommonGarden/Grow-IoT/blob/f61d62b396b85f6c160cf174e8dda20b14794483/tests/test-device.js . Isn't it is better than copy pasting uuid&token every time someone wants to start testing?
@JakeHartnell What about taking uuid and token as arguments from command in tests/test-device.js.? https://github.com/CommonGarden/Grow-IoT/blob/f61d62b396b85f6c160cf174e8dda20b14794483/tests/test-device.js . Isn't it is better than copy pasting uuid&token every time someone wants to start testing?
Good idea. We need better testing infrastructure...
@JakeHartnell A start https://github.com/CommonGarden/Grow-IoT/tree/arun-tests.
User Story
[x] test device selects graphs, according to event type.
[x] grow elements demand data they need from test device. import/ui/components/grow-elements/demand-behaviors.js
[x] tests/test-device.js takes in arguments.
node tests/test-device.js [uuid] [token] [type]
example:
Tasks
What's this PR do? List the related issues also
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots (if appropriate)
Questions: