CommonGarden / Grow-IoT

Software packages for smart growing environments.
http://commongarden.org/
Other
25 stars 6 forks source link

Update ESLint #437

Closed newswim closed 6 years ago

newswim commented 6 years ago

The .eslintrc file is pretty out of date.

# run linter
> yarn lint
$ eslint .
/Users/dm/github/CommonGarden/Grow-IoT/packages/graphql-api/node_modules/cors/.eslintrc:
    Configuration for rule "quotes" is invalid:
    Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '"single"').

Error: /Users/dm/github/CommonGarden/Grow-IoT/packages/graphql-api/node_modules/cors/.eslintrc:
    Configuration for rule "quotes" is invalid:
    Severity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '"single"').

# the bigger fish to fry
(node:9169) DeprecationWarning: [eslint] The 'ecmaFeatures' config file property is deprecated, and has no effect. (found in /Users/dm/github/CommonGarden/Grow-IoT/.eslintrc)

Improvement plan

  1. Update eslint in devDependencies, port/replace existing configuration to follow newer practices.

(or) 2. Switch to prettier.

JakeHartnell commented 6 years ago

eslint has been updated, we should use it more.