search

CommonWealthRobotics / bowler-kernel

The heart of the Bowler stack.
http://commonwealthrobotics.com/
GNU Lesser General Public License v3.0
7 stars 0 forks source link

Add support for SSH Git URLs #78

Open Octogonapus opened 4 years ago

Octogonapus commented 4 years ago

Describe the bug

When trying to run a script using an SSH Git URL (e.g. git@github.com:CommonWealthRobotics/bowler-kernel-test-repo.git), you are not allowed

java.lang.IllegalArgumentException: The supplied Git URL (git@github.com:CommonWealthRobotics/bowler-kernel-test-repo.git) was not a valid repository or Gist URL.
    at com.commonwealthrobotics.bowlerkernel.gitfs.GitHubFS$Companion.gitUrlToDirectory$gitfs(GitHubFS.kt:332)
    at com.commonwealthrobotics.bowlerkernel.gitfs.GitHubFS$cloneRepo$1.invoke(GitHubFS.kt:64)
    at com.commonwealthrobotics.bowlerkernel.gitfs.GitHubFS$cloneRepo$1.invoke(GitHubFS.kt:48)

Steps To Reproduce

Expected behavior

We should support SSH URLs.

Additional Information

Octogonapus commented 4 years ago

It looks like JGit has trouble with this. Moving to the icebox for now.