search

Commonists / CommonsDownloader

Tool to download thumbnails of files from Wikimedia Commons
MIT License
28 stars 16 forks source link

CommonsDownloader should allow to download the full-size image #11

Open JeanFred opened 9 years ago

JeanFred commented 9 years ago

Requested by Coyau: wants CommonsDownloader to download the full-size file.

JeanFred commented 9 years ago

On the back end this is not really hard − we already fetch the fullsize when requesting too big a size (since #2) The UX aspect is what worries me − how to select this? Another argument --full-size``on the command line, exclusive with the--width` flag? But what about the file list option?

maflcko commented 9 years ago

What about assuming the user wants the full size if no size is specified?

JeanFred commented 9 years ago

@MarcoFalke Thanks for chiming in! That’s a good question − CommonsDownloader started its life as a thumbnail grabber so this was the original assumption which we can certainly revisit :)

The issue I have with this is that Wikimedia Commons files can be quite big (and some are properly huge) − not sure it is a nice experience to fire CommonsDownloader and end up downloading by default megabytes and megabytes. What do you think?

maflcko commented 9 years ago

It really depends on where or by whom your application is used...

But if you want to change the current behavior as little as possible, what about using --width=-1 to request the full size. (Same behavior as the actual mediawiki API)