Upgrade code for Python 3.7

Commonists / CommonsDownloader

Tool to download thumbnails of files from Wikimedia Commons

MIT License

28 stars 16 forks source link

Upgrade code for Python 3.7 #15

Open Johnson145 opened 5 years ago

Johnson145 commented 5 years ago

Not sure whether this repository gets still maintained, but I've updated the code to work with Python 3.7.

SahilAshar commented 4 years ago

it doesn't look like this repo is actively maintained anymore - but thanks for conversion! It might be useful to make an issue as well that links to this PR.

JeanFred commented 4 years ago

Hi! Sorry − I completely missed this post last August…

Wow, I did not even think that anyone would care much about that repo! Thanks for working on it, i’m more than happy to merge this.

JeanFred commented 4 years ago

Ok, I took some time to fix the build on master and the tests are passing again. However there are test failures under Python3 − would need investigation

SahilAshar commented 4 years ago

There was also an issue with one of the imports in thumbnaildownload.py -> it needs to be import urllib.request instead of just import urllib. That got it working for me.