search

Commonjava / indy

Simple artifact proxy for maven and similar build tools
Apache License 2.0
33 stars 30 forks source link

Update field name PackagePath.scoped #2422

Closed ruhan1 closed 7 months ago

ruhan1 commented 7 months ago

When I test promote service I hit "missing property" error of 'PackagePath.isScoped'. I corrected the name according to bean standard, and the err is gone. That class is copied from Indy. I guess we will hit the same issue in the future, e.g, when upgrading to newer dependency lib. So I port the fix here.

sswguo commented 7 months ago

LGTM.

ruhan1 commented 7 months ago

Maybe just a convention. For boolean field, name it normally, e.g, x. Its get method would be 'isX'. we better not name the filed to 'isX'. Otherwise the method by default would be 'isIsX'. Some libraries may depend on the convention.

ligangty commented 7 months ago

Maybe just a convention. For boolean field, name it normally, e.g, x. Its get method would be 'isX'. we better not name the filed to 'isX'. Otherwise the method by default would be 'isIsX'. Some libraries may depend on the convention.

Oh ok. I misunderstand this "bean standard" as some npm metadata file format convention. That's ok.