search

CommonplaceRobotics / iRC_ROS

ROS2 packages for the igus Robot Control
Apache License 2.0
15 stars 7 forks source link

Package dependency refers to rviz version 1 not 2 #106

Closed robin-mueller closed 11 months ago

robin-mueller commented 11 months ago

Description The dependency for rviz in the desciption package and the hardware package refers to rviz whereas it should be rviz2.

Your environment

ROS Distro: Humble
OS Version: Ubuntu 22.04
Branch/Commit hash: humble #3d485ad

To Reproduce Running rosdep check --from-paths src/iRC_ROS/.

Result

...
ERROR[irc_ros_description]: Cannot locate rosdep definition for [rviz]
        rosdep key : rviz
        OS name    : ubuntu
        OS version : jammy
        Data:
<no data>

...
ERROR[irc_ros_hardware]: Cannot locate rosdep definition for [rviz]
        rosdep key : rviz
        OS name    : ubuntu
        OS version : jammy
        Data:
<no data>
...

If rviz is substituted with rviz2 in the package.xml linked above the error won't occur.

cpr-fer commented 11 months ago

Hi @robin-mueller

Thank you for your two issues! I just created a PR that should fix the issue, I'll merge it after testing it on my machine as well