CommonplaceRobotics / iRC_ROS

ROS2 packages for the igus Robot Control
Apache License 2.0
15 stars 7 forks source link

Fix controllers.yaml loading #68

Closed cpr-fer closed 1 year ago

cpr-fer commented 1 year ago

Followup of #62

The movegroups moveit controllers parameter does not work with the same approach as other yaml files. As such ReplaceString() cant be used and the joint prefixes have to be hardcoded. This makes multi-robot setups harder to use and should be fixed

This does not work as moveit expects a dictionary and not a file for the parameter.

moveit_controllers_file = PathJoinSubstitution(
    [
        FindPackageShare("irc_ros_moveit_config"),
        "config",
        "moveit_controllers.yaml",
    ]
 )
moveit_controllers = ReplaceString(
    source_file=moveit_controllers_file,
    replacements={
         "<namespace>": namespace,
         "<prefix>": prefix,
    },
)
cpr-fer commented 1 year ago

Was fixed in #30