marthendalnunes
commented
3 years ago Awesome work @mendesfabio the performance improvement just by changing to a custom template is impressive! Just a few feedbacks:
- The changes were not made on the
hatch.py, only ontest-hatch.py. Probably it was intentional to keep the changes just in one file and after it is finished copy to the other, but just keeping the reminder here. - At the initial loading the markdown is rendered before the plots and sliders:
- It would be nice to have the TEC logo as we have on the react template:
- The react template uses a busy indicator that is useful when the plots take a little longer to render. Since the response time is better with this custom template, this busy indicator might no be that necessary 🤔
- The target IH rate HLine is wrong, maybe just pulling the changes in the dev branch will fix it 😉
- It would be nice to add a Favicon with the TEC logo
- The dandelion voting legend could be on the left upper corner where there is more empty space
- The "play with my params" link is redirecting to app.py and raising a 404 error
- The parameter importing is not working (I've cloned your branch and it's raising some errors on params assignments)
@mendesfabio instead of TECH can we just say "Hatch"
And instead of DandelionVoting can we say "TEC Hatch DAO"