search

CommonsSwarm / tec-convert

Convert between your Aragon tokens
https://convert.tecommons.org
3 stars 11 forks source link

Manage exit tribute properly #4

Closed sembrestels closed 3 years ago

sembrestels commented 3 years ago

The tribute is not applied in the frontend conversion and can mislead on how much collateral you are going to receive when selling bonded tokens.

The entry tribute and exit tribute should appear just below The conversion amount is an estimate, you can take inspiration from uniswap/honeyswap's liquidity provider fee:

Screenshot from 2020-11-28 23-07-08

GriffGreen commented 3 years ago

you should see how much you get, the exit tribute currently goes to the funding pool so the front end says you get 100... but really you get 80 and 20 goes to the funding pool!

fioreb commented 3 years ago

Here you can find the design for this: https://www.figma.com/file/3qP2tcfrhZegRQD9aFLOQe/Convert?node-id=3%3A551

Harthor commented 3 years ago

working on this notion doc https://www.notion.so/sha256/https-github-com-TECommons-tec-convert-issues-4-19501b281b6e437f9fd48f79c6bd1f0c