search

CommonsSwarm / tec-convert

Convert between your Aragon tokens
https://convert.tecommons.org
3 stars 11 forks source link

Address is not properly detected when it's switched #6

Closed sembrestels closed 3 years ago

sembrestels commented 3 years ago

Steps to reproduce:

  1. Enable account with Account 1
  2. Switch to Account 2 with metamask
  3. Convert some bonded tokens to collateral (TEC to xDAI)
  4. The transaction can not be done because Account 2 is not detected Screenshot from 2020-11-14 11-52-02 Screenshot from 2020-11-14 11-52-22
daithi-coombes commented 3 years ago

Was only able to recreate once last night. Haven't been able to so since.

Have tried ff, chromium, brave and only recreated once with Brave. Have found this issue but although same error I don't think its because of a bad payload, as it the error would then persist. (answer got 3 ups).

Also the latest metamask (in ff) gives option to switch account when doing step 2 in OP. Running the master branch of convert

@sembrestels can you still recreate this? If so what browser/metamask & os were you using? Also is there a deployed version of convert that the issue is persistent in (maybe npm is using different web3/dependency on my local)

GriffGreen commented 3 years ago

weird!

vivianedias commented 3 years ago

@sembrestels I dont think this issue is a problem anymore, because Metamask ignores if you changed accounts and only signals that you are connected to one but switched in the app.

The user flow is to just do the transaction with the selected account in the app.

marthendalnunes commented 3 years ago

@mendesfabio @PabloCGL can you guys reproduce this error? I've been trying here but it seems to work fine.