search

CommonsSwarm / tec-convert

Convert between your Aragon tokens
https://convert.tecommons.org
3 stars 11 forks source link

fix token balances and add metamask button #61

Closed mendesfabio closed 2 years ago

mendesfabio commented 2 years ago

This PR make the token balances to use spendableBalance instead of tokenBalance -- this has been leading the locked tokens being accounted when clicking in Convert All button. Besides that, I created a button to add TEC token to MetaMask.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for rinkeby-convert-tecommons ready!

🔨 Explore the source changes: 308fe271a418faea37db3b13ef3064547c0fd1f5

🔍 Inspect the deploy log: https://app.netlify.com/sites/rinkeby-convert-tecommons/deploys/61f97f5e0cb55200072ae9f8

😎 Browse the preview: https://deploy-preview-61--rinkeby-convert-tecommons.netlify.app

GriffGreen commented 2 years ago

Tried the deploy preview but couldnt see the metamask button... nor could i test the locked vs unlocked tokens

Screen Shot 2022-02-02 at 11 36 11 AM Screen Shot 2022-02-02 at 11 36 37 AM Screen Shot 2022-02-02 at 11 37 16 AM
mendesfabio commented 2 years ago

@GriffGreen FYI, I added a simple Add TEC to MM button only to the success page; that's why you didn't find it. Also, someone didn't correctly configure the previews here -- my PR is into production, but the preview shows a development version that might have addresses/contracts out of date. I deployed the dApp to my own Netlify for testing: https://clever-wozniak-ca6d29.netlify.app/.

GriffGreen commented 2 years ago

This looked good to me! Thx for the local deploy

0xNuggan commented 2 years ago

The netlify worked good for me too