CommonsSwarm / tec-hatch

Front end for the Hatch
https://hatch.tecommons.org/
3 stars 11 forks source link

For refunding with vesting, calculate how much they vested and add that to another burn #123

Open GriffGreen opened 3 years ago

GriffGreen commented 3 years ago
  1. 🚨 _refund() should check if the vesting's cliff date has been reached when calculating the amount to burn: because refund() can be called at any time, a user who waits until after the cliff period to be refunded may experience odd behaviour (either they receive some vested tokens or are unable to process the refund because the token manager fails to burn the expected amount of tokens)
GriffGreen commented 3 years ago

see https://brettsun.notion.site/Augmented-Bonding-Curve-Review-6dfc203017f34b7a9eca5807fa0609cd