Community-A-4E / community-a4e-c

The Community Repo for A-4E-C and its Official Submods
598 stars 87 forks source link

add individual trim speed settings #535

Closed Drofseh closed 2 years ago

Drofseh commented 2 years ago

close #534

Drofseh commented 2 years ago

I've flown with this in a couple missions now and it's working well, but it might be better to just make the a setting a slider from 1 to 100 and then divide the setting input by 100 to get 0.01 to 1.

That would be more customizable for the end user and also reduce all the elseif code to just a single division per trim setting axis.

Thoughts?

callmepartario commented 2 years ago

Sure - I'm not sure how to make a slider in the UI, though. Is that available?

callmepartario commented 2 years ago

i'll take a look through some other modules and see what i can dig up from their special configs.

callmepartario commented 2 years ago

okay, yeah, this looks possible. lemme play around with it - if i can get that going, i'll merge you in and take it from there.

callmepartario commented 2 years ago

I've gone ahead and added these changes in my own commit at https://github.com/heclak/community-a4e-c/commit/d29acd0a17decd9b56f2b4534e42b1138403e8c3 -- thanks for the guide, it made it a snap. I made three sliders and respaced the special menu out.

You can safely fold these changes into your existing install if you like! I also added you to the contibutors list in the readme.

Drofseh commented 2 years ago

Sounds good to me! I am drofseh in the A-4E discord if you want to give me the contributor tag there as well ;)

Drofseh commented 2 years ago

It looks like you missed this though, so the sliders won't actually apply the trim rates to roll and rudder.

https://github.com/heclak/community-a4e-c/pull/535/files#diff-58808eae6ef1284c19b977e23fae3b4a505f17539dd799b3dc894b24ece50113R247-R329

Drofseh commented 2 years ago

Oh, maybe I'm reading https://github.com/heclak/community-a4e-c/commit/d29acd0a17decd9b56f2b4534e42b1138403e8c3 wrong I think I'm correct