search

Community-A-4E / community-a4e-c

The Community Repo for A-4E-C and its Official Submods
598 stars 87 forks source link

Sounds missing from ground units when the A-4E-C is installed #580

Closed callmepartario closed 1 year ago

callmepartario commented 2 years ago

Engine sounds are missing for most of the tanks/APC's when the A-4E-C is installed, for example, the T-80U. Apparently this is also affecting other mods, for example, the UH-60L.

Software Information (please complete the following information):

See also: https://forum.dcs.world/topic/311925-combined-arms-engine-sounds-missing/

Woulve commented 1 year ago

I have the same Problem.

twanmal commented 1 year ago

same here, tested with and without the mod. When testing with the hercules mod 6.8.2, there were no problem to hear the T-80U

DDFriar commented 1 year ago

Hi, I have found the same issue as well. I made this test video. https://www.youtube.com/watch?v=fh-iwoJ--Lg&ab_channel=DD_Friar

08jne01 commented 1 year ago

Thanks for the detailed reports all, I'm investigating this one.

DDFriar commented 1 year ago

@08jne01 - Many thanks. I should have stated that I was in the Open Beta version in case that makes a difference, which I am sure it might, but then what do I know! I did ask one of the DCS Beta testers about this and if they would be investigating from their end but he replied to say that his brief is to check on errors in the vanilla version and that the onus lays with mods to interact with DCS not the other way round so I have my fingers crossed that you may be able to find a solution as it is such a great plane, we have it as a mandatory mod on our server.

08jne01 commented 1 year ago

This is fixed on develop if you want the fix before the next update just download the develop branch and replace your current install Sounders folder with the folder from the develop branch.

This folder here. https://github.com/heclak/community-a4e-c/tree/develop/A-4E-C/Sounds/Sounders

DDFriar commented 1 year ago

WoW - that is excellent news, many many thanks. I will relay the news to our server managers as well. Salute.

08jne01 commented 1 year ago

@08jne01 - Many thanks. I should have stated that I was in the Open Beta version in case that makes a difference, which I am sure it might, but then what do I know! I did ask one of the DCS Beta testers about this and if they would be investigating from their end but he replied to say that his brief is to check on errors in the vanilla version and that the onus lays with mods to interact with DCS not the other way round so I have my fingers crossed that you may be able to find a solution as it is such a great plane, we have it as a mandatory mod on our server.

Yea DCS sounders are very old and not used by most stuff now, ED hid all the sound files a while back but the sounders rely on these hidden files so it's easy to cause a bug in their system because our file would technically overwrite theirs. Getting them working was finicky but now that they are working I was able to go through and actually figure out what files were necessary or not.

08jne01 commented 1 year ago

WoW - that is excellent news, many many thanks. I will relay the news to our server managers as well. Salute.

Yea just bear in mind if you use the fix above it's Sounders (with an S on the end) you don't need to replace the Sound folder as the one on github does not have the actual A-4 sound files they are stored elsewhere.

DDFriar commented 1 year ago

Sorry, meant to ask - when is the next full update planned for? if it is not too far away I may wait for the official update?

08jne01 commented 1 year ago

Sorry, meant to ask - when is the next full update planned for? if it is not too far away I may wait for the official update?

It's generally whenever plusnine and I get time to do it, I'm pretty busy at work at the moment and I know plusnine is busy too, so it might be a little while.

DDFriar commented 1 year ago

ok thanks.

DDFriar commented 1 year ago

Salute. We applied the fix and unsurprisingly, (you obviously know what you are doing!) it worked. We can now hear tank engines with the A4-E enabled. As the no sound issue was also being caused by the Bronco, I hope you dont mind but I took the logic you had applied to your files (renaming the tools file and addressing it in the engine file also referencing the Curve file) and replicated it in the Bronco files and that fixed that plane as well. Would you be ok with me going public on this fix, giving you full credit for providing the fix of course or would you rather leave it until you produce an update?

08jne01 commented 1 year ago

Salute. We applied the fix and unsurprisingly, (you obviously know what you are doing!) it worked. We can now hear tank engines with the A4-E enabled. As the no sound issue was also being caused by the Bronco, I hope you dont mind but I took the logic you had applied to your files (renaming the tools file and addressing it in the engine file also referencing the Curve file) and replicated it in the Bronco files and that fixed that plane as well. Would you be ok with me going public on this fix, giving you full credit for providing the fix of course or would you rather leave it until you produce an update?

You don't need the Curve file that's our own sound tools, but feel free to make the other changes you see.

DDFriar commented 1 year ago

@08jne01 Ok, many thanks.

Drofseh commented 1 year ago

@DDFriar if you could share your Bronco fix with me I'd appreciate it

DDFriar commented 1 year ago

Salute I am away from home at the moment. I get back home tonight (Thursday). It is then my intention to publish the fixes on the DCS Combined Arms forum.

But all we did was to copy the logic you built into your fix. We renamed the tools.lua to OV-10ATools.lua We edited the engine file (I can't remember the name at the moment I think it is J.... something) We changed the dofile("tools.lua") to be dofile("OV-10ATools.lua") We also added a second line dofile("Curve.lua")

and that's it, it worked!

Salute and many thanks for your excellent plane once again.

Kind regards DD_Friar Colin

------ Original Message ------ From: "Drofseh" @.> To: "heclak/community-a4e-c" @.> Cc: "DDFriar" @.>; "Mention" @.> Sent: Thursday, 23 Feb, 2023 At 04:58 Subject: Re: [heclak/community-a4e-c] Sounds missing from ground units when the A-4E-C is installed (Issue #580)

@DDFriar https://github.com/DDFriar if you could share your Bronco fix with me I'd appreciate it — Reply to this email directly, view it on GitHub https://github.com/heclak/community-a4e-c/issues/580#issuecomment-1441219622 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A6AKGAMWIF4YQFFYEFZ5BLLWY3U7LANCNFSM6AAAAAAR76KJAE . You are receiving this because you were mentioned.Message ID: @.***>

DDFriar commented 1 year ago

EDIT: There is no Curve file for the Bronco so disregard that bit of the fix.

callmepartario commented 1 year ago

fixed in 2.1.1!