Misc issues with autoscripts. - Githubissues

CommunityCube / debian-autoscript

GNU General Public License v2.0

20 stars 14 forks source link

Misc issues with autoscripts. #6

Open htgoebel opened 9 years ago

htgoebel commented 9 years ago

Hi, here are some issues I found when scanning ovter the scripts:

Should not ping google nor access google in any other way (autoscript-network)
Should test for $(id -u) == 0 instead of using whoami.
Must not delete ssh-hostkeys without asking
Should not overwrite /etc/hosts without asking and without backup
Must not change hostname without asking
Should not overwrite interface defintiions without asking and without backup
Must not overwrite other files without backup, e.g. /etc/dhcp/dhcpd.conf
Yacr-Ip-Adresse within DHCP-range?
Should not use "random" NTP-servers by IP-address
Unbound is configured twice: in system and in services.
Use ferm instead of configuring iptables manually.