search

CommunityDragon / CDTB

A library containing everything to extract files from client files.
GNU Lesser General Public License v3.0
119 stars 33 forks source link

Add 2 new methods to hashes.py and other minor changes #13

Closed Morilli closed 5 years ago

Morilli commented 5 years ago

Again, this is probably not perfect, but the general idea should be pretty clear. Also has support for the new .luabin64™ files.

Morilli commented 5 years ago

I made some proof of concept changes to the multi_substitution function. It should preserve the current functionality for lcu but make providing a custom list of paths and words possibly. Please review on whether this is what you asked for or whether I should be using a different approach altogether.

benoitryder commented 5 years ago

Customization of paths and words is good. What about the customization of "changes" (number of words to add for instance)?

Morilli commented 5 years ago

If we're gonna do that, I feel like it would be possible to merge these two functions into substitute_basename_words and add_basename_word, just with different amounts of words of to replace to be specified. Does that sound fair to you?

benoitryder commented 5 years ago

Yep! all good!

Morilli commented 5 years ago

I think I covered everything now, tell me if something is still wrong / unwanted.