search

CommunityDragon / CDTB

A library containing everything to extract files from client files.
GNU Lesser General Public License v3.0
119 stars 33 forks source link

Add AssociatedTraits and IncompatibleTraits to TFT item and augment data #71

Closed SamGuthrie closed 1 year ago

SamGuthrie commented 1 year ago

Adds AssociatedTraits and IncompatibleTraits from map22.bin to item and augment data.

AssociatedTraits seems to be the rules that augments use for being offered, and is useful to associate an augment with the trait it gives ie. "TFT8_Augment_InterPolarisTrait" (LaserCorps Heart) gives +1 "Set8_SpaceCorps"

IncompatibleTraits (not sure why its named this but kept the name) seems to be the trait that spatula items are associated with ie "TFT8_Item_OxForceEmblemItem" (OxForce emblem) gives +1 "Set8_OxForce"

bangingheads commented 1 year ago

The rest of the properties in this json are camel cased so stylistically I'd like to see them changed to associatedTraits and incompatibleTraits

SamGuthrie commented 1 year ago

Sure, should be updated in the latest commit

SamGuthrie commented 1 year ago

Agreed and done :)