search

CommunityDragon / Data

A place for keeping and discussing additional data we plan to provide through CDragon.
44 stars 12 forks source link

Thornmail field 'name' in 10.24/cdragon/tft/en_us.json is wrong #26

Open SamnnyWong opened 3 years ago

SamnnyWong commented 3 years ago

http://raw.communitydragon.org/10.24/cdragon/tft/en_us.json http://raw.communitydragon.org/10.23/cdragon/tft/en_us.json simply search "game_item_displayname_3075" in the above json file, thornmail's "name" field is "game_item_displayname_3075" and not "thornmail", I double check http://raw.communitydragon.org/10.22/cdragon/tft/en_us.json which shows "thornmail".

Is this a bug?

bangingheads commented 3 years ago

With the item rework of preseason in League of Legends, Thornmail's key went from game_item_displayname_3075 to Item_3075_Name.

Since Thornmail is a discontinued item in TFT, Riot has not updated the item in the game files to reflect these changes.

From the CDragon side this is expected behavior as game_item_displayname_3075 is no longer in the RST.

SamnnyWong commented 3 years ago

Is there a way to figure out which item is active and which is not? I noticed that some items with an id that is negative and some with a large number id (10003, 10004, 10001, etc..) But other than that everything seems normal but there are some item is inactive but with a normal id. Is there any characteristic about inactive items? Thanks in advance.

the-higgs commented 3 years ago

Is there a way to figure out which item is active and which is not? I noticed that some items with an id that is negative and some with a large number id (10003, 10004, 10001, etc..) But other than that everything seems normal but there are some item is inactive but with a normal id. Is there any characteristic about inactive items? Thanks in advance.

Have you figured that out? I am also having the same issue, wondering if the information can be derived from other files...