search

CommunityGD32Cores / ArduinoCore-GD32

Arduino core for GD32 devices, community developed, based on original GigaDevice's core
Other
92 stars 33 forks source link

gpio_interrupt.c bug #114

Closed cNavsky closed 2 days ago

cNavsky commented 11 months ago

Bugs in cores/arduino/gd32/gpio_interrupt.c.

  1. in function "gpio_interrupt_enable" RCU_CFGCMP clock is not enabled. As a result, adding interrupt to any pin on any port except PORTA will not work. Fix: add "rcu_periph_clock_enable(RCU_CFGCMP);"

  2. same function, "GD32E23x" is missing from #if defined conditions for in "syscfg_exti_line_config". As a result, EXTI line never configured for GD32E23x chip, interrupt not working for anything except PORTA pins. Fix: add "GD32E23x" to#if defined conditions.

maxgerhardt commented 11 months ago

Thanks for the report. As I see it, RCU_CFGCMP exists for GD32E23x, F1x0 and F3x0, but is only enabled for the latter two, so it's not working on E23x.

maxgerhardt commented 11 months ago

Fix attempted in https://github.com/CommunityGD32Cores/ArduinoCore-GD32/commit/047bc6f7c338f3e7619bfde433a313a2c98e6e4b, please cross-check / pull neweset version.

maxgerhardt commented 2 days ago

Assuming fix worked.