search

CommunityGD32Cores / ArduinoCore-GD32

Arduino core for GD32 devices, community developed, based on original GigaDevice's core
Other
89 stars 33 forks source link

typo trasnmit -> transmit #115

Closed owennewo closed 9 months ago

owennewo commented 9 months ago

There is a typo in the struct 

can_trasnmit_message_struct

It should be:

can_transmit_message_struct

As this is a key struct it should be changed before it is used too much by peoply like me :)

maxgerhardt commented 9 months ago

That is unfortunately changing the Gigadevice provided SDK files.. We already had to make modifications for those to be fully C++ compatible and fix I2C clock bugs, but I'm not sure whether we should do that for renaming a structure.. CAN messages should be abstracted away by the Arduino API layer in any case. If that is not the case right now, that's where we should start. On the other path, I need to deduce a patch system that applies our custom patches to SDK versions, so that they're kept track of and easily reapplyable when we update the SPL.

owennewo commented 9 months ago

OK - so anything in /system/GD32* comes from gigadevice. I'll close this PR as it isn't going anywhere for the time being.