search

CommunityGD32Cores / ArduinoCore-GD32

Arduino core for GD32 devices, community developed, based on original GigaDevice's core
Other
92 stars 33 forks source link

Servo code missing original copyright #30

Closed michaelmargolis closed 3 years ago

michaelmargolis commented 3 years ago

The code for the servo class and header are copied from the Arduino AVR source code but the copyright statements have been removed. Please ensure that all copyright material used in this repository include existing copyright statements

maxgerhardt commented 3 years ago

The servo class implementation can impossibly be from the AVR core because it uses HardwareTimer, that doesn't exist in the AVR core.

https://github.com/CommunityGD32Cores/ArduinoCore-GD32/blob/2f1adfb0d687db72b0598ea3c3bbf217a0446ce5/libraries/Servo/src/Servo.cpp#L1-L4

I'll review the header more closely.

maxgerhardt commented 3 years ago

The header seems to be mostly from

https://github.com/arduino-libraries/Servo/blob/f3617664917ff1a46c2c3db5300d27054ba147cc/src/Servo.h#L80-L122

that is correct. Will add.

maxgerhardt commented 3 years ago

Resolved in a68917a6c70a91eae9ae04624eb27f02fc11f475, 2b34964f3c066bf9da0c849cd96a3f86a3ae121e, ca0173f5dd71cadbf2ee01f5d76bcb417eeaddf9 and 50134d93cd1689015ce1a5e00ef7d8b07da1bd5d

michaelmargolis commented 3 years ago

Thank you for your prompt reply.

Although the interrupt code is different, the Servo class appears identical. In this case you can add the copyright of the author of interrupt code to the original copyright.

Michael Margolis (author of the servo code)

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Maximilian @.> Sent: 05 August 2021 19:19 To: @.> Cc: Michael @.>; @.> Subject: Re: [CommunityGD32Cores/ArduinoCore-GD32] Servo code missing original copyright (#30)

The servo class can impossibly be from the AVR core because it uses HardwareTimer, that doesn't exist in the AVR core.

https://github.com/CommunityGD32Cores/ArduinoCore-GD32/blob/2f1adfb0d687db72b0598ea3c3bbf217a0446ce5/libraries/Servo/src/Servo.cpp#L1-L4

I'll review the header more closely.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/CommunityGD32Cores/ArduinoCore-GD32/issues/30#issuecomment-893681205, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAENQYWMXAXQOJAPME2CWMDT3LI4NANCNFSM5BUL6HAA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

maxgerhardt commented 3 years ago

All done already, see above commit references.

michaelmargolis commented 3 years ago

thanks and have fun with the project

Michael

From: Maximilian Gerhardt @.> Sent: 05 August 2021 19:50 To: CommunityGD32Cores/ArduinoCore-GD32 @.> Cc: Michael Margolis @.>; Author @.> Subject: Re: [CommunityGD32Cores/ArduinoCore-GD32] Servo code missing original copyright (#30)

All done already, see above commit references.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/CommunityGD32Cores/ArduinoCore-GD32/issues/30#issuecomment-893698954, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAENQYTLLZ3NWVYXLX7NLYLT3LMPXANCNFSM5BUL6HAA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.