search

CommunityGD32Cores / ArduinoCore-GD32

Arduino core for GD32 devices, community developed, based on original GigaDevice's core
Other
86 stars 33 forks source link

UART Pins should match existing common practice. #38

Closed obra closed 2 years ago

obra commented 2 years ago

From max:

todo note: equalize default uart pins between arduino and SPL UART examples

What STM32 duino does for a bluepill yeah they also do PA9, what we do in SPL.

ifndef PIN_SERIAL_RX

define PIN_SERIAL_RX PA10

endif

ifndef PIN_SERIAL_TX

define PIN_SERIAL_TX PA9

endif

https://github.com/stm32duino/Arduino_Core_STM32/blob/master/variants/STM32F1xx/F103C8T_F103CB(TU)/variant_PILL_F103Cx.h#L140-L145

maxgerhardt commented 2 years ago

Fixed per https://github.com/CommunityGD32Cores/ArduinoCore-GD32/commit/2616a45b0d8a46ae3735b2c86e0b87f9a03f50c4, now the GD32F303CC_GENERIC uses PA9 for standard UART TX (and PA10 for RX), just like the SPL examples do and just like STM32Duino for a Bluepill does.

The old behavior (TX = PA2) can be restored by defining the macro USE_USART1_SERIAL in the build process, e.g. with PlatformIO, through build_flags.