CommunityGD32Cores / ArduinoCore-GD32

Arduino core for GD32 devices, community developed, based on original GigaDevice's core
Other
85 stars 33 forks source link

GD32F350CB "Not declared" error on Arduino 1.8.13 #86

Closed ldicdican closed 1 year ago

ldicdican commented 1 year ago

https://github.com/CommunityGD32Cores/ArduinoCore-GD32/blob/c2bfff7740ec2dc58478a5eddaa537c49b7df885/variants/GD32F350CB_GENERIC/PeripheralNames.h#L42

(int)DAC0 -> (int)DAC

maxgerhardt commented 1 year ago

Thanks, we'll have to correct that in the generation script (without breaking the other chips for which this is correct)

https://github.com/CommunityGD32Cores/platform-gd32/blob/main/misc/scripts/gd32_genpinmap/pinmap_converter.py

maxgerhardt commented 1 year ago

Fixed in https://github.com/CommunityGD32Cores/platform-gd32/commit/77f0bcd0e5328a9a28849392f1a471e858c70d77 and https://github.com/CommunityGD32Cores/ArduinoCore-GD32/commit/7b597ba8fb08af6e382e2e1a9617ed673b4afeee