search

CommunityToolkit / ColorCode-Universal

This is a port of ColorCode to .NET Standard. The original Html only formatter has been separated from the Logic, so now it can produce Syntax Highlighted code for any output. This Project can currently produce HTML, and Render to UWP RichTextBlocks.
Other
222 stars 42 forks source link

'csharp' name missing for aliases #1

Closed michael-hawker closed 6 years ago

michael-hawker commented 7 years ago

I think GitHub uses csharp as an identifier:

public class Test {
...
}

But it's not looked for here: https://github.com/WilliamABradley/ColorCode-Universal/blob/master/ColorCode.Core/Compilation/Languages/CSharp.cs#L117 (which I think is what's used for the matching?)

WilliamABradley commented 7 years ago

Those just contain the Alternate Aliases, the Language ID is csharp, which is checked against first.

If you look at the Xml Language, it checks xml first, and I added XAML and AXML to the list. Some languages have no Aliases, like I believe Fortran.

michael-hawker commented 7 years ago

Is that the LanguageId? As they have c# instead of csharp so we'd need the other as the alias still, eh?

WilliamABradley commented 7 years ago

Thats true, I'll fix that.