ghost
commented
3 years ago Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌
Fixes #86
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the roaming settings work is located in the UWP directory, making it only usable in UWP apps. It is also based on the older ObjectStorage interfaces in WCT, which are being deprecated in the near future.
What is the new behavior?
The roaming settings helpers have been majorly refactored and most importantly simplified! The new code is much easier to work with in my opinion, but it is also segmented a little differently.
Old, removed ❌
CommunityToolkit.Graph.Uwppackage:Helpers/RoamingSettings/BaseRoamingSettingsDataStore.csHelpers/RoamingSettings/IRoamingSettingsDataStore.csHelpers/RoamingSettings/OneDriveDataStore.csHelpers/RoamingSettings/RoamingSettingsHelper.csHelpers/RoamingSettings/UserExtensionDataStore.csNew, improved ✨
CommunityToolkit.Graphpackage:Helpers/RoamingSettings/IRemoteSettingsStorageHelper.cs- Defines basic sync functionality for a remote settings storage location. Based on the WCT preview interface,ISettingsStorageHelper.Helpers/RoamingSettings/OneDriveDataSource.cs- Internal class for handling Graph operations with OneDrive.Helpers/RoamingSettings/OneDriveStorageHelper.cs- Helper for storing files in OneDrive via Graph. Based on the WCT previewIFileStorageHelperinterface.Helpers/RoamingSettings/UserExtensionDataSource.cs- Internal class for handling Graph operations with user extensions.Helpers/RoamingSettings/UserExtensionStorageHelper.cs- Helper for storing settings metadata in open extensions on the Graph User object. Based onIRemoteSettingsStorageHelper.PR Checklist
Please check if your PR fulfills the following requirements:
TODO:
Microsoft.Toolkitnuget dependency once new WCT storage helper interfaces are released.