CommunityToolkit / Graph-Controls

Set of Helpers and Controls for Windows development using the Microsoft Graph.
https://docs.microsoft.com/en-us/windows/communitytoolkit/graph/overview
Other
155 stars 39 forks source link

Fixes #149 - Update Sample to use External ObservableCollection #160

Closed michael-hawker closed 3 years ago

michael-hawker commented 3 years ago

Fixes #149

We re-write the sample to use an external collection as a developer would in their app. This then properly lets the ItemsControl display just the tokenized items. (Though there's still an issue with how TokenizingTextBox behaves we should resolve.)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Trying to point to the ItemsSource of the TokenizingTextBox gives us the wrong collection.

What is the new behavior?

We use an external collection (as a developer would bind to their data model) and use that to bind to both the TTB and the ItemsControl. Then it works as intended.

Will open an issue on the main repo for tracking a fix to the underlying TTB.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

ghost commented 3 years ago

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌