CommunityToolkit / Graph-Controls

Set of Helpers and Controls for Windows development using the Microsoft Graph.
https://docs.microsoft.com/en-us/windows/communitytoolkit/graph/overview
Other
155 stars 39 forks source link

Avoid adding empty providers #191

Closed Richasy closed 2 years ago

Richasy commented 2 years ago

Fixes #190

PR Type

What kind of change does this PR introduce?

What is the current behavior?

When adding a WebAccountProvider, there is no null judgment on the acquired provider, resulting in a null reference in the provider added to the list, which directly causes an unexpected provider (null) to be passed in when the WebAccountProviderCommand is created, causing the process to be interrupted and unable to log in.

What is the new behavior?

Create a new method and add it to the list only when the obtained WebAccountProvider is not null.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

shweaver-MSFT commented 2 years ago

Need to clean up the build error, but otherwise looks good to me :)

michael-hawker commented 2 years ago

Looks like it may have been a NuGet timeout trying to restore packages, reran the job, so we'll see what happens.