CommunityToolkit / Graph-Controls

Set of Helpers and Controls for Windows development using the Microsoft Graph.
https://docs.microsoft.com/en-us/windows/communitytoolkit/graph/overview
Other
155 stars 39 forks source link

MsalProvider constructor crashes unless you pass scopes #195

Open asklar opened 2 years ago

asklar commented 2 years ago

https://github.com/CommunityToolkit/Graph-Controls/blob/d985141a317c96ad571bd9dd8097e38969b649d6/CommunityToolkit.Authentication.Msal/MsalProvider.cs#L63

the default value for scopes is null, but we unconditionally run the Select(...) on it. Fix would be to either not provide a default argument for scopes (since it's arguably needed), or at least use scopes?.Select(...) so that we don't end up with a null deref. note there's 2 ctors with this issue

ghost commented 2 years ago

Hello asklar, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌