Closed michael-hawker closed 1 year ago
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌
@Niels9001 @Arlodotexe mind taking a look? Think this is a fairly straight-forward swap out in the end; but took a bit of trial and error (realized tests are interactive currently, and build variable wasn't being replaced).
Would like to merge this in the morning and then close out the remaining open PRs together so we can get a new 7.1.3 out. I notified @Richasy to help test out the PR bits as well in comparison to 7.1.2 to ensure we don't get any surprises.
Though did a quick comparison in NuGet Package Explorer:
7.1.2 packages:
New PR packages:
Outside of the signing step (which was unchanged, just not done for PRs), the package construction looks identical to me.
Not sure of the old behavior of the Unit Tests, or something changed with an MSAL update or something:
Seems to have to do with auto-signin but setting that property to false doesn't help. We'll have to shore up tests in the future later if we invest more in larger changes and investments to the library in the future.
Existing Build got broken with environment changes it seems, so worked to bring us up to VS 2022 VM and build system on .NET 6.
Includes:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Can't Build repo in VS 2022 and in CI
What is the new behavior?
Can build in VS 2022 locally, on commandline, and in CI
PR Checklist
Please check if your PR fulfills the following requirements:
Other information