CommunityToolkit / Graph-Controls

Set of Helpers and Controls for Windows development using the Microsoft Graph.
https://docs.microsoft.com/en-us/windows/communitytoolkit/graph/overview
Other
156 stars 39 forks source link

Custom CalendarView #48

Open 0pd opened 7 years ago

0pd commented 7 years ago

Default CalendarView lacks range selection feature which is a common calendar use case.

This feature requires new appearance settings like border cell and middle cell styles so it can't be attached to default control in a simple manner.

Discuss.

skendrot commented 7 years ago

Are you thinking something that opens a view with three months viewable at once and allowing the user to pick the start/end dates?

0pd commented 7 years ago

The view in general is the same.

skendrot commented 7 years ago

The same as? The current CalendarView? Can you provide some images of how you think this would look?

0pd commented 7 years ago

Same as UWP CalendarView. I'm not a designer and I can't share my company's design.

Basic idea is to provide a style of selected cell (single date / period borders) and a style of cells between period borders (if the period was selected). And of course the behaviour of selection.

May be the text customization is also important, for example user may need capitalize day names (it's just a general DataTemplate for cell, may be).

skendrot commented 7 years ago

Like two boxes for the start and end? One box that contains both the start and the end?

jneidlinger commented 7 years ago

@skendrot I'm assuming @llvk is talking about something similar to this (Android implementation)

calendarselect

I think you could actually accomplish something like this with use of the CalendarView control's "black out" date functionality + some clever styling - though the implementation might be a little hairy.

andrewleader commented 7 years ago

In addition to that, here's what I personally need from a CalendarView

image

Custom items on each day, custom UI on each day ("+" button on the day appears when mouse hovers).

I had to build my own custom calendar control. I would much rather use a better designed custom calendar control. The one included in UWP XAML doesn't let you do any of this.

skendrot commented 7 years ago

@anbare sounds like you've already built this control. Would you want to submit a PR?

andrewleader commented 7 years ago

Mine doesn't follow the standard ItemTemplate and other practices that actual XAML controls follow (it's mostly custom-built for my purposes)... it might be easy for me to re-factor it, I could look into it... but I don't have a lot of free time, so if anyone else has something, I'm happy to let them submit something.

Here's some requirements that I think would allow the control to achieve everyone's goals

skendrot commented 7 years ago

@anbare Great starting point for a CalendarEntry type control. This is of course different than what @llvk originally started this thread about. They would both be good additions

0pd commented 7 years ago

@anbare up/down swipe is more evident (for mouse interaction consistency), isn't it?

deltakosh commented 7 years ago

I added SDKCHECK label to point this discussion to XAML team ad they may be interested by this feedback

IbraheemOsama commented 7 years ago

@nmetulev this issue needs a SDK check :P

windowstoolkitbot commented 7 years ago

This issue seems inactive. It will automatically be closed in 14 days if there is no activity.

gillesbergerp commented 6 years ago

I just wanted to ask, if there are some news on this topic. I'm highly interested in a standalone calendar control - the built-in just offers far too less customization options.

nmetulev commented 6 years ago

There is no updates, we should have a uservoice entry for this in order to gauge the need of the community. Do you mind creating one here?

gillesbergerp commented 6 years ago

I just created a uservoice entry. It can be found here.

nmetulev commented 6 years ago

Nice, time to spread the word :)

michael-hawker commented 6 years ago

This gets a little easier now with the UniformGrid control we're adding in 3.0 (PR windows-toolkit/WindowsCommunityToolkit#1975). I even made the sample app sample a simple calendar. So it could be a good starting point for someone looking into this in the future.

lucaasrojas commented 6 years ago

Whats the current status of this issue?

michael-hawker commented 5 years ago

This could be a good candidate to open a request on the WinUI Controls repo to pull the CalendarView with improvements in there.

michael-hawker commented 5 years ago

I don't know if we'll go into the full depth of requirements laid out above, but we definitely are thinking of Calendar type controls for our work from the connections to the Microsoft Graph, so I see this as something we'll be thinking of more later this year.

vitor-antonio commented 4 years ago

I actually did a small work around on the calendar view, and created a kind of custom range calendar control. Its quite basic but does the job of enabling first date and end date selection and then select the dates in between. If anyone is interested I could potentially shared the code!

Cheers!

michael-hawker commented 4 years ago

Going to move this to our Graph repo, as I believe anything we do in this area we'd also want to be integrable with the Graph.

ghost commented 4 years ago

Hello 0pd, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌