search

CommunityToolkit / Labs-Windows

A safe space to collaborate and engineer solutions from the prototyping stage all the way through polished finalized component for the Windows Community Toolkit.
Other
344 stars 50 forks source link

Port TextToolBar #594

Open niels9001 opened 1 year ago

niels9001 commented 1 year ago 
### Base Porting Checklist
- [ ] Component name (to `CommunityToolkit.WinUI.Controls.TextToolBar`)
- [ ] Redesign, following the latest WinUI design guidelines
- [ ] Merge differences from UWP main to WinAppSDK / Uno forks
- [ ] Support for WASM via Uno Platform
- [ ] Improve Samples
- [ ] All brought over tests pass for UWP/WinAppSDK
### Known Issues
### Improvements

Notable Changes

N/A

electro-logic commented 1 month ago

UWP TextToolBar (Microsoft.Toolkit.Uwp.UI.Controls.TextToolbar) is missing from the CommunityToolkit.Uwp.Controls.* and is preventing some projects upgrade. Are there any plan to port it to the latest nuget packages? UWP only version would be nice, WinUI can be for the future

michael-hawker commented 2 days ago

@electro-logic it's not something that's been on our radar, but we're happy to take a PR in Labs to start the process. Our new infrastructure supports targeting both UWP and WinUI out of the box, so just taking the WinUI code from the old repo as a starting point should get things most of the way.