search

CommunityToolkit / MVVM-Samples

Sample repo for MVVM package
Other
1.11k stars 222 forks source link

C# Code in Collections example seems to be the same as that in RelayCommand #112

Open dmedine opened 1 year ago

dmedine commented 1 year ago

ViewModel code appears to be unfinished: https://github.com/CommunityToolkit/MVVM-Samples/blob/master/samples/MvvmSample.Core/ViewModels/CollectionsPageViewModel.cs#L1-L15

The text for the C# in the View is the same as the text for the C# in the RelayCommand view: https://github.com/CommunityToolkit/MVVM-Samples/blob/8963a8720dc783658e764e22629598509e044d7f/samples/MvvmSampleUwp/Views/CollectionsPage.xaml#L139-L159 https://github.com/CommunityToolkit/MVVM-Samples/blob/master/samples/MvvmSampleUwp/Views/RelayCommandPage.xaml#L47-L76

michael-hawker commented 1 year ago

I just went to go look at this sample and found the same thing. FYI @Sergio0694

I believe this is the ViewModel being used here: https://github.com/CommunityToolkit/MVVM-Samples/blob/master/samples/MvvmSample.Core/ViewModels/Widgets/ContactsListWidgetViewModel.cs

Not sure where the CollectionsPageViewModel is used, that's something else.